Update testing environment #21
Conversation
abachma2
added
Difficulty:1-Beginner
| container: | ||
| image: alpine:3.14 |
There was a problem hiding this comment.
I've never used a container in GH actions. What's the function?
There was a problem hiding this comment.
It's for running on a Docker image. I don't think this is actually needed here. I'll remove it if it isn't.
There was a problem hiding this comment.
It looks like the docker image is needed. It's a standard Linux environment that is minimal in size: https://hub.docker.com/_/alpine/
| on: | ||
| # allows us to run workflows manually | ||
| workflow_dispatch: | ||
| pull_request: |
There was a problem hiding this comment.
So this will only run when a pull request is created. On subsequent pushes to that PR it will not run. Not sure if this is the behavior you want or not.
There was a problem hiding this comment.
No, it will run again if you push to the branch the PR originates from:
Runs your workflow when activity on a pull request in the workflow's repository occurs.
For example, if no activity types are specified, the workflow runs when a pull request
is opened or reopened or when the head branch of the pull request is updated.
from https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows
There was a problem hiding this comment.
May want to add a push trigger
| - name: Install dependencies | ||
| run: | | ||
| pip install pytest | ||
| mamba env update -n openmcyclus-env -f environment.yml | ||
| mamba install -y cycamore openmc scipy=1.11 pytest |
There was a problem hiding this comment.
Thanks! This may not stay for long, as I'm noticing locally that when cyclus is installed locally it isn't able to find the archetype. I'll dig into this a bit more.
There was a problem hiding this comment.
When I run the CI with the mamba build see run 129, I think it finds cyclus. So this build configuration will stay.
The alpine 3.14 docker container is needed to run the ``apk`` command to install the latest version of git
| on: | ||
| # allows us to run workflows manually | ||
| workflow_dispatch: | ||
| pull_request: |
There was a problem hiding this comment.
May want to add a push trigger
| container: | ||
| image: alpine:3.14 |
| on: | ||
| # allows us to run workflows manually | ||
| workflow_dispatch: | ||
| pull_request: |
There was a problem hiding this comment.
No, it will run again if you push to the branch the PR originates from:
Runs your workflow when activity on a pull request in the workflow's repository occurs.
For example, if no activity types are specified, the workflow runs when a pull request
is opened or reopened or when the head branch of the pull request is updated.
from https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows
| - name: Install dependencies | ||
| run: | | ||
| pip install pytest | ||
| mamba env update -n openmcyclus-env -f environment.yml | ||
| mamba install -y cycamore openmc scipy=1.11 pytest |
There was a problem hiding this comment.
Thanks! This may not stay for long, as I'm noticing locally that when cyclus is installed locally it isn't able to find the archetype. I'll dig into this a bit more.
| container: | ||
| image: alpine:3.14 |
There was a problem hiding this comment.
It's for running on a Docker image. I don't think this is actually needed here. I'll remove it if it isn't.
Adding this function makes the tests more sustaiable, as the cross section data stored in the ANL link may change slightly with time
|
Is there anything else for this PR? I think the timeline got a little messy because I requested a review without actually finishing my updates/responding to comments. @yardasol |
This PR updates the testing environment with two primary parts: